fix(cmd/gf): run AddSigHandlerShutdown cannot work well)#4441
Merged
hailaz merged 4 commits intogogf:masterfrom Sep 23, 2025
Merged
fix(cmd/gf): run AddSigHandlerShutdown cannot work well)#4441hailaz merged 4 commits intogogf:masterfrom
hailaz merged 4 commits intogogf:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes signal handling for process termination in the gf command tool to address platform-specific differences between Windows and Unix-like systems. The fix addresses the issue where AddSigHandlerShutdown cannot work properly on Windows due to signal handling limitations.
- Adds platform-specific signal handling logic that gracefully terminates processes on Unix-like systems while falling back to force kill on Windows
- Implements a timeout mechanism for graceful shutdown attempts to prevent hanging processes
- Separates signal-based termination from direct kill operations based on the operating system
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
waitCtx, cancel := context.WithTimeout(ctx, 30*time.Second) 我加了ctx控制协程退出 |
hailaz
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3752
Sending [Interrupt] on Windows is not implemented.