feat(container/gring): add generic ring feature#4496
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a generic ring data structure (TRing[T]) to the container/gring package and refactors the existing deprecated Ring type to use it internally. The implementation provides type-safe ring buffer operations while maintaining backward compatibility.
Key changes:
- Added
TRing[T], a generic ring structure with thread-safe operations for any type - Refactored deprecated
Ringto wrapTRing[any], eliminating code duplication - Created type alias
internalRingItempointing tointernalTRingItem[any]for consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| container/gring/gring_t.go | Implements the new generic TRing[T] structure with all ring operations (set, get, move, link, unlink, iterate) |
| container/gring/gring.go | Refactors deprecated Ring to use TRing[any] as embedded field, delegating all operations to the generic implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ize slice initialization in SliceNext/SlicePrev
hailaz
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add TRing