fix(contrib/config/apollo):where gcfg config apollo failed to retrieve configurations for multiple namespaces, where watch apollo change resulted in missing configurations.#4509
Merged
hailaz merged 3 commits intogogf:masterfrom Nov 19, 2025
Conversation
…ations for multiple namespaces; fixed an issue where `watch apollo change` resulted in missing configurations.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the Apollo configuration adapter when handling multiple namespaces. The changes enable proper retrieval and watching of configurations from comma-separated namespace values.
- Added support for parsing comma-separated namespaces in the
NamespaceNameconfiguration field - Updated the
Available()method to verify all configured namespaces are accessible - Modified
updateLocalValue()to iterate through all namespaces and merge their configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rim for namespace handling
hailaz
approved these changes
Nov 19, 2025
gcfg config apollo failed to retrieve configurations for multiple namespaces, where watch apollo change resulted in missing configurations.gcfg config apollo failed to retrieve configurations for multiple namespaces, where watch apollo change resulted in missing configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where
gcfg config apollofailed to retrieve configurations for multiple namespaces; fixed an issue wherewatch apollo changeresulted in missing configurations.