fix(net/goai): add openapi uuid.UUID type support#4604
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves Go-to-OpenAPI type mapping by adding support for uuid.UUID types and refactoring the type detection logic for better organization and efficiency.
Changes:
- Added explicit handling for
uuid.UUIDtype to map toTypeStringin OpenAPI schemas - Refactored type-specific checks to occur before kind-based checks for improved clarity and performance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic in
golangTypeToOAITypeto improve how Go types are mapped to OpenAPI types. The most important changes are focused on handling specific struct and slice types more accurately, ensuring better compatibility with OpenAPI specifications.Type mapping improvements:
[]uint8anduuid.UUIDtypes, mapping both toTypeString. This ensures these commonly used types are correctly represented in OpenAPI schemas.time.Time,gtime.Time,ghttp.UploadFile,[]uint8, anduuid.UUID) before falling back to the kind-based mapping. This improves accuracy for special-case types.