feat(contrib/registry/nacos): add SetDefaultEndpoint and SetDefaultMetadata methods#4608
Merged
hailaz merged 3 commits intogogf:masterfrom Jan 15, 2026
Merged
feat(contrib/registry/nacos): add SetDefaultEndpoint and SetDefaultMetadata methods#4608hailaz merged 3 commits intogogf:masterfrom
hailaz merged 3 commits intogogf:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configurable default endpoint and metadata support to the Nacos registry, allowing developers to programmatically override service endpoints and merge additional metadata during registration instead of relying solely on environment variables.
Changes:
- Add
defaultEndpointanddefaultMetadatafields to Registry struct - Add
SetDefaultEndpointandSetDefaultMetadatamethods for configuration - Update
Registermethod to apply configured defaults during service registration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| contrib/registry/nacos/nacos.go | Adds struct fields and setter methods for default endpoint and metadata configuration |
| contrib/registry/nacos/nacos_register.go | Updates Register method to apply default endpoint override and merge default metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hailaz
approved these changes
Jan 15, 2026
Contributor
|
fixed #4609 |
lingcoder
added a commit
to lingcoder/gf
that referenced
this pull request
Jan 23, 2026
…methods - Remove defaultEndpoint and defaultMetadata fields that cause data race when SetDefaultMetadata/SetDefaultEndpoint and Register are called concurrently - Remove SetDefaultEndpoint and SetDefaultMetadata methods (introduced in PR gogf#4608) - Mark SetClusterName and SetGroupName as deprecated with warning about concurrency safety and future removal Closes gogf#4649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable default endpoint and metadata support to nacos Registry,
providing a more flexible alternative to hardcoded environment variable reads.