fix(database/gdb): skip field filtering when table/alias is unknown in FieldsPrefix#4602
Merged
hailaz merged 1 commit intogogf:masterfrom Jan 15, 2026
Merged
Conversation
eb01b5c to
7b9e020
Compare
7b9e020 to
5dde1c5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where FieldsPrefix silently drops fields when called with an alias before the alias is established via LeftJoin. The fix adds logic to skip field filtering when the table/alias is unknown (not yet registered in the model).
Changes:
- Added early return in
mappingAndFilterToTableFieldswhen a table/alias is unknown and not the main table - Added comprehensive test coverage for the fix in the PostgreSQL driver
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| database/gdb/gdb_model_utility.go | Added check to skip field filtering when table/alias is unknown (i.e., not yet registered via LeftJoin) |
| contrib/drivers/pgsql/pgsql_z_unit_issue_test.go | Added Test_Issue4595 with 3 test cases covering FieldsPrefix before/after LeftJoin and Fields with prefix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #4595