feat(contrib/registry): update nacos sdk to 2.3.5#4628
Merged
gqcn merged 3 commits intogogf:masterfrom Jan 22, 2026
Merged
Conversation
Contributor
yuluo-yx
commented
Jan 18, 2026
- Update nacos go sdk to 2.3.5;
- ctx params not use, skip it;
- adjust docs style
Signed-off-by: yuluo-yx <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nacos Go SDK from version 2.3.3 to 2.3.5 and makes minor code improvements related to unused context parameters and documentation formatting.
Changes:
- Updated nacos-sdk-go/v2 dependency from v2.3.3 to v2.3.5
- Replaced unused
ctx context.Contextparameters with_in Register, Deregister, and Search methods - Improved README.MD formatting by adding blank lines between sections and removing trailing whitespace
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| contrib/registry/nacos/go.mod | Updated nacos-sdk-go/v2 dependency to version 2.3.5 |
| contrib/registry/nacos/go.sum | Added checksums for nacos-sdk-go/v2 v2.3.5 |
| contrib/registry/nacos/nacos.go | Updated function comment for NewWithConfig |
| contrib/registry/nacos/nacos_register.go | Renamed unused ctx parameter to _ in Register and Deregister methods |
| contrib/registry/nacos/nacos_discovery.go | Renamed unused ctx parameter to _ in Search method |
| contrib/registry/nacos/README.MD | Improved documentation formatting with consistent blank lines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gqcn
approved these changes
Jan 21, 2026
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.