fix(cmd/gf): fix gf gen enums output path error when using relative path#4636
Merged
gqcn merged 1 commit intogogf:masterfrom Jan 21, 2026
Merged
fix(cmd/gf): fix gf gen enums output path error when using relative path#4636gqcn merged 1 commit intogogf:masterfrom
gqcn merged 1 commit intogogf:masterfrom
Conversation
…ath (gogf#4387) The output file was incorrectly created relative to source directory instead of current working directory due to Chdir before writing file. Now converts output path to absolute before Chdir and restores original working directory after.
gqcn
approved these changes
Jan 21, 2026
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gf gen enumsoutput file created at wrong location when using relative pathdefer gfile.Chdir(originPwd)to restore original working directoryRoot Cause
The code calls
gfile.Chdir(realPath)to change to source directory beforegfile.PutContents(in.Path, ...), causing relative output path to be resolved relative to source directory.Solution
gfile.Abs()beforeChdirdefer(followinggenpb.gopattern)Test Cases
Test_Gen_Enums_Issue4387_RelativePath- standard project with relative pathTest_Gen_Enums_AbsolutePath- absolute path (should work as before)Test_Gen_Enums_Issue4387_Monorepo- monorepo mode (cd app/xxx && gf gen enums)Closes #4387