Prevent symlink attacks in repo file updates #8070
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a security check to `UpdateRepoFile` method in `repo_editor.go` to prevent symlink attacks. Before writing to a file, it now checks if the target path is a symlink. This change addresses CVE-2025-8110 by ensuring that attackers cannot exploit the API to write through symlinks to sensitive files, such as `.git/config`, thereby enhancing the security of the repository editing process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Added a security check to
UpdateRepoFilemethod inrepo_editor.goto prevent symlink attacks. Before writing to a file, it now checks if the target path is a symlink. This change addresses CVE-2025-8110 by ensuring that attackers cannot exploit the API to write through symlinks to sensitive files, such as.git/config, thereby enhancing the security of the repository editing process.Link to the issue: https://nvd.nist.gov/vuln/detail/CVE-2025-8110
Checklist