feat(status-code): allow custom status codes #188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindilevich
reviewed
May 26, 2021
There was a problem hiding this comment.
It is a marvelous solution! Much more elegant than mine is! Two questions here:
- Why the call to
sendFailureatwas left unattended? Do we want to be able to provide an option for a custom status code there too?Line 68 in 6b4f496
- What should I do with my PR (#187)? How'd I cancel it so you can advance yours?
Thank you!
|
@sindilevich thanks for your patience here - I'll clean up this draft PR sometimes this week. Will keep you posted! |
|
Sure thing, @gergelyke, thank you! |
|
closing this PR as this was handled in #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.