-
Couldn't load subscription status.
- Fork 95
custom header support #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there any movement on this? We've come up against a CORS issue that this functionality would allow us to solve. Would be great if this could get in. |
|
@ste2425 Going to resolve the requested change today! |
|
Hey @gergelyke-dd! I can't re-request a review so I just wanted to tag you to tell you I finished the changes! |
|
Looks great! One question: with the introduction of res.writeHead, do we still need the res.status = β¦ lines? |
|
@gergelyke good call! Just removed them and tested. Everything still works and the res.status is gone! |
|
one last thing before we land it , would you mind adding some test coverage? |
|
@gergelyke just added test coverage! |
|
awesome, thank you π |
|
π This PR is included in version 4.10.0 π The release is available on:
Your semantic-release bot π¦π |
fixes #195
An example on how to write headers would be:
I tested it to enable CORS headers and everything seems to be working!