Handle two-value assignments in locals and helper migrations #177
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces two-phase regex-based transformations in MigrateGenericHelpers to handle both complex tuple assignments and simple calls for Params*/Query* to generic fiber wrappers. Extends middleware locals migration to support two-variable LHS by appending a boolean on RHS. Updates corresponding tests to reflect new patterns and expectations. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Src as Source Go Code
participant Mig as MigrateGenericHelpers
participant P1 as Phase 1: Tuple Assign Rewrite
participant P2 as Phase 2: Simple Call Rewrite
participant Out as Transformed Code
Src->>Mig: Code containing ParamsInt/Query* usages
Mig->>P1: Apply *_Assign regexes
Note over P1: Rewrite "A, B := c.QueryInt(...)"<br/>to "A, B := fiber.Query[int](c, ...), nil"
P1-->>Mig: Partially transformed code
Mig->>P2: Apply simple Params/Query regexes
Note over P2: Rewrite direct calls<br/>to fiber.Params[T]/Query[T]
P2-->>Out: Final code
sequenceDiagram
autonumber
participant Src as Source Go Code
participant Mid as Middleware Locals Migrator
participant Pat as Tuple LHS Handler
participant Out as Transformed Code
Src->>Mid: "csrfToken, ok := c.Locals(...).(string)"
Mid->>Pat: Detect two LHS vars
Note over Pat: Replace "XFromContext(ctx)"<br/>with "XFromContext(ctx), true"<br/>to satisfy arity
Pat-->>Out: "csrfToken, ok := csrf.TokenFromContext(c), true"
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello @ReneWerner87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the migration tools by correctly handling two-value assignments in Go. Specifically, it ensures that when Params/Query helper functions are migrated to generic versions, a nil is appended for the second return value (typically an error). Similarly, for middleware locals migrations, a true is appended for the second return value (typically an ok boolean). This prevents compilation errors and ensures the migrated code remains syntactically and semantically correct for these specific patterns.
Highlights
- Improved Generic Helper Migrations: The migration tool for
fiber.Paramsandfiber.Queryhelpers now correctly handles two-value assignments (e.g.,val, err := ...), appending, nilto the new generic helper call to maintain compatibility with error handling. - Enhanced Middleware Locals Migrations: The migration tool for
c.Localsnow correctly transforms two-value assignments (e.g.,val, ok := ...) by appending, trueto theFromContextcall, preserving theokboolean. - Updated Test Coverage: New and modified test cases ensure the migration tools correctly apply these two-value assignment transformations for both generic helpers and middleware locals.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly handles two-value assignments in migration scripts for middleware locals and generic helpers. The changes are well-tested. My main feedback is a suggestion to refactor the repetitive code in generic_helpers.go to improve maintainability.
Summary
, true, nilfor two-value assignments when replacing Params/Query helpers with generic versionsTesting
make lintmake testhttps://chatgpt.com/codex/tasks/task_e_68aa13f966248326ba45cb5fa55a8f43
Summary by CodeRabbit
New Features
Tests