Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add migration for cache middleware CacheControl rename #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReneWerner87 merged 2 commits into from
Nov 30, 2025
Merged

Add migration for cache middleware CacheControl rename #230

ReneWerner87 merged 2 commits into from
Nov 30, 2025

Conversation

@ReneWerner87
Copy link
Member

@ReneWerner87 ReneWerner87 commented Nov 29, 2025

Summary

  • update the cache middleware migration to convert CacheControl to DisableCacheControl with inverted semantics and avoid remigrating updated configs
  • add migration tests covering CacheControl literal and expression cases plus idempotency

Testing

  • make lint
  • make test

Codex Task

@ReneWerner87 ReneWerner87 requested a review from a team as a code owner November 29, 2025 16:37
@ReneWerner87 ReneWerner87 requested review from efectn, gaby and sixcolors and removed request for a team November 29, 2025 16:37
@ReneWerner87 ReneWerner87 added the ✏️ Feature New feature or request label Nov 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2025 •
edited
Loading

Warning

Rate limit exceeded

@ReneWerner87 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 72f3762 and 7c89179.

📒 Files selected for processing (2)
  • cmd/internal/migrations/v3/cache_config.go (1 hunks)
  • cmd/internal/migrations/v3/cache_config_test.go (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/2025-11-29-16-37-36

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 29, 2025

Summary of Changes

Hello @ReneWerner87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial update to the v3 migration script for the cache middleware. It addresses a breaking change where the CacheControl configuration field was renamed to DisableCacheControl and its semantic meaning inverted. The changes ensure that existing configurations are automatically and correctly transformed, preventing issues for users upgrading to the new version. The inclusion of comprehensive tests guarantees the reliability and idempotency of this migration process.

Highlights

  • Cache Middleware Migration Update: The migration script for cache.Config has been updated to handle the rename of the CacheControl field to DisableCacheControl. This involves inverting the boolean logic during the conversion.
  • Robust Migration Logic: The migration now correctly processes various forms of boolean expressions for CacheControl, including true, false, direct variable references, and negated expressions (e.g., !cfg.DisableCacheHeaders).
  • Comprehensive Migration Tests: New tests have been added to verify the migration's correctness for literal boolean values and complex expressions, as well as to ensure the migration is idempotent, meaning it can be run multiple times without unintended side effects.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@ReneWerner87 ReneWerner87 mentioned this pull request Nov 29, 2025
Merged
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a migration script to rename CacheControl to DisableCacheControl with inverted semantics. The implementation is mostly correct and includes good test coverage. However, I've found a potential bug in the regex-based replacement logic where it doesn't correctly handle comments, which could lead to syntax errors in the migrated code. I've provided a suggestion to fix this and also recommended enhancing the tests to cover these edge cases. Overall, a good contribution that will be solid after addressing the feedback.

@ReneWerner87
Copy link
Member Author

ReneWerner87 commented Nov 30, 2025

/gemini review
@coderabbitai review

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 30, 2025

Thanks for requesting a review, @ReneWerner87! I'm starting my detailed code review now and will post my findings shortly.

@coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2025

@ReneWerner87: I'll review the changes in this pull request.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ReneWerner87 ReneWerner87 merged commit 76a5764 into master Nov 30, 2025
13 of 14 checks passed
@ReneWerner87 ReneWerner87 deleted the codex/2025-11-29-16-37-36 branch November 30, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaby gaby Awaiting requested review from gaby gaby is a code owner automatically assigned from gofiber/maintainers

@sixcolors sixcolors Awaiting requested review from sixcolors sixcolors is a code owner automatically assigned from gofiber/maintainers

@efectn efectn Awaiting requested review from efectn efectn is a code owner automatically assigned from gofiber/maintainers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

codex ✏️ Feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReneWerner87