Summary of Changes

Hello @gaby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the reliability and safety of the DefaultReq.Port() function by making it resilient to diverse network address types. The changes prevent potential panics by gracefully handling non-TCP addresses and ensure correct port extraction or appropriate fallback behavior for various remote address formats. This also includes a substantial increase in test coverage to validate the new logic.

Highlights

• Robust Port Extraction: The DefaultReq.Port() function has been refactored to handle various net.Addr implementations more robustly, preventing panics that could occur with non-TCP addresses.
• Type Switch Implementation: The function now uses a type switch to specifically handle *net.TCPAddr (extracting the port), *net.UnixAddr (returning an empty string), and falls back to net.SplitHostPort for other net.Addr types.
• Error Constant Removal: The errTCPAddrTypeAssertion constant has been removed from errors_internal.go as it is no longer needed due to the improved port extraction logic.
• Enhanced Test Coverage: A new table-driven unit test, Test_Ctx_Port_RemoteAddrVariants, has been added to ctx_test.go to ensure 100% coverage for the Port() function across various remote address scenarios, including TCP, Unix sockets, nil addresses, string-based host:port, and IPv6 addresses.
• Test Utility: A testNetAddr struct was introduced in ctx_test.go to facilitate testing with custom string-style net.Addr values.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Walkthrough

Port() was made more robust: it now safely handles various net.Addr implementations (nil, *net.TCPAddr, *net.UnixAddr, and other String()-based addresses) via a type switch and fallback parsing. Tests were added to verify port extraction across multiple remote address variants, including IPv6 and missing ports.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

• sixcolors
• ReneWerner87
• efectn

Poem

🐰 I hopped through nets with gentle art,
Ports parsed clean from every part;
No sudden panic, calm and bright,
TCP, Unix, IPv6 — all right! 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.16%. Comparing base (eec1258) to head (7e601e8).
⚠️ Report is 3 commits behind head on main.

@@            Coverage Diff             @@
##             main    #4051      +/-   ##
==========================================
- Coverage   91.21%   91.16%   -0.05%     
==========================================
  Files         119      119              
  Lines       11121    11129       +8     
==========================================
+ Hits        10144    10146       +2     
- Misses        620      625       +5     
- Partials      357      358       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.