Thanks to visit codestin.com
Credit goes to github.com

Skip to content

v3: router: return status 501 instead of 400 on unknown method #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReneWerner87 merged 3 commits into from
Nov 15, 2022
Merged

v3: router: return status 501 instead of 400 on unknown method #2220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c54202
router: return status 501 instead of 400 on unknown method
leonklingele Nov 14, 2022
a968925
router: ensure to always release context
leonklingele Nov 14, 2022
b6a1392
ctx: fix tests
leonklingele Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ctx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,8 +1402,8 @@ func Test_Ctx_InvalidMethod(t *testing.T) {

app.Handler()(fctx)

require.Equal(t, 400, fctx.Response.StatusCode())
require.Equal(t, []byte("Invalid http method"), fctx.Response.Body())
require.Equal(t, 501, fctx.Response.StatusCode())
require.Equal(t, []byte("Not Implemented"), fctx.Response.Body())
}

// go test -run Test_Ctx_MultipartForm
Expand Down
7 changes: 2 additions & 5 deletions router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,11 @@ func (app *App) handler(rctx *fasthttp.RequestCtx) {
c = app.AcquireCtx().(*DefaultCtx)
}
c.Reset(rctx)
defer app.ReleaseCtx(c)

// handle invalid http method directly
if methodInt(c.Method()) == -1 {
_ = c.Status(StatusBadRequest).SendString("Invalid http method")
app.ReleaseCtx(c)
_ = c.SendStatus(StatusNotImplemented)
return
}

Expand All @@ -224,9 +224,6 @@ func (app *App) handler(rctx *fasthttp.RequestCtx) {
_ = c.SendStatus(StatusInternalServerError)
}
}

// Release Ctx
app.ReleaseCtx(c)
}

func (app *App) addPrefixToRoute(prefix string, route *Route) *Route {
Expand Down