Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary UUID counter check #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReneWerner87 merged 4 commits into from
Dec 12, 2025
Merged

Remove unnecessary UUID counter check #170

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70d3684
Remove unnecessary UUID counter check that could panic
sixcolors Dec 9, 2025
39bfd2a
fix: improve error handling in UUID seeding to use fmt.Errorf
sixcolors Dec 9, 2025
d3e76ce
fix: improve panic message formatting in UUIDv4 function
sixcolors Dec 9, 2025
4349ea2
fix: improve error wrapping in UUID generator seeding
sixcolors Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,10 @@ func UUID() string {
// Setup seed & counter once
uuidSetup.Do(func() {
if _, err := rand.Read(uuidSeed[:]); err != nil {
panic(fmt.Sprintf("utils: failed to seed UUID generator: %v", err))
panic(fmt.Errorf("utils: failed to seed UUID generator: %w", err))
}
uuidCounter = binary.LittleEndian.Uint64(uuidSeed[:8])
})
if atomic.LoadUint64(&uuidCounter) <= 0 {
panic("utils: UUID generator not properly seeded")
}
// first 8 bytes differ, taking a slice of the first 16 bytes
x := atomic.AddUint64(&uuidCounter, 1)
_uuid := uuidSeed
Expand Down Expand Up @@ -94,7 +91,7 @@ func UUID() string {
func UUIDv4() string {
token, err := uuid.NewRandom()
if err != nil {
panic(fmt.Sprintf("utils: failed to generate secure UUID: %v", err))
panic(fmt.Errorf("utils: failed to generate secure UUID: %w", err))
}
return token.String()
}
Expand Down
Loading