Update doc.md #1518
Merged
Update doc.md #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the icon and colour configuration file more clear, as the names and locations of both files were not explicitly stated.
joelim-work
reviewed
Dec 3, 2023
Collaborator
joelim-work
left a comment
There was a problem hiding this comment.
Thanks for the patch, but have you considered Windows users? Although I'm quite sure that the majority of lf users are on Linux, I do not believe the documentation should make this assumption.
I think we can instead add something along the lines of Please refer to the Configuration section for more information.
Also edited the English for spelling and grammar mistakes.
Contributor
Author
|
Added your recommendation in this commit. |
joelim-work
approved these changes
Dec 3, 2023
Collaborator
joelim-work
left a comment
There was a problem hiding this comment.
Cool, thank you for taking the time to go through the documentation and fix up all the spelling/grammar errors 👍
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the icon and colour configuration file more clear, as the names and locations of both files were not explicitly stated.
I had to search around for quite a bit to figure out where to place the icon and colour configuration files.