fix basename being . when it is empty
#1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelim-work
reviewed
Dec 6, 2023
Collaborator
joelim-work
left a comment
There was a problem hiding this comment.
Thanks for your patch, I can reproduce the issue as well.
About your changes, filepath.Base is already called a few lines above to remove the leading path components, so I don't think it is required again, and instead the following code should work:
basename := file[:len(file)-len(ext)]Or alternatively:
basename := strings.TrimSuffix(file, ext)
Contributor
Author
|
thanks for taking a look, updated |
joelim-work
approved these changes
Dec 7, 2023
Collaborator
joelim-work
left a comment
There was a problem hiding this comment.
Looks good, thanks once again for the bugfix.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filepath.Base("")is.. so when copying a hidden file like.gitignoreto the same place, it becomes..gitignore.~1~this PR fixes the case when basename should be empty