Remove experimental locale feature #2111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going through the set of features available in
lfand resolving all of the ones that are marked as experimental. It turns out thatlocaleis the only experimental feature, which I must decide whether to accept it in full (removing its experimental status), or to reject it completely.While I can respect the need for users to sort based on locale, I have decided on this occasion to reject this feature, for the following reasons:
statfields such as name/mtime/size, although exceptions are made for cases like natural sorting and sorting by extension as they are frequently required by users.go-localeas a dependency. While there is likely nothing wrong withgo-localeitself, in general having more dependencies means more risk, and I am hesitant to keep this for a feature that I don't consider as widely used.text/collatepackage is updated once in a while, and I have to briefly test changes before merging Dependabot bumps. It is not a big deal, but still requires some effort on my part.lf(i.e. make features simple but extensible, rather than trying to patch in direct support for everything).