-
Notifications
You must be signed in to change notification settings - Fork 360
Hide already typed keys inside showbinds menu
#2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @joelim-work. With this one, I would like to hear your thoughts. |
joelim-work
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting me know about this change.
I think it is not worth making the content of the showbinds menu configurable, and it is better to just provide a fixed implementation that is reasonable (using other file managers as a reference).
The idea of hiding characters that are already typed is fine. I did notice that you only check the first character though, what should the behavior be if the mapping uses more than two characters? What do other file managers do in this case?
map bar echo bar
map baz echo baz
|
I think it's better to pass in |
|
Ok, it seems to be more complicated than that. # The key hint lists up to this size have their sublists expanded.
# Otherwise the submaps are replaced with "...".
set hint_collapse_threshold 10It only seems to show "..." if the amount of completions exceeds
I'd say we just show every remaining key to keep it simple. |
showbinds menu furthershowbinds menu
modeinshowbindsmenu #2228This PR aims to align the design of the
showbindsmenu even further to other terminal file managers. It changes the following:keystokeyshowbinds,mapscommand still shows the complete key sequence)