Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@CatsDeservePets
Copy link
Collaborator

No description provided.

@CatsDeservePets CatsDeservePets added the breaking Pull requests that introduce breaking changes label Nov 13, 2025
@CatsDeservePets CatsDeservePets marked this pull request as ready for review November 13, 2025 21:39
@CatsDeservePets
Copy link
Collaborator Author

@joelim-work

This is a weird one. Maybe I am thinking to deep about this.

Release r37 added a deprecation message to globfilter which was removed in r38. The sixel option has been deprecated in r38. However, the changelog says it has been removed, not deprecated.

Now, I want to remove the deprecation message for sixel. What wording should I use for the changelog?
"The deprecated sixel option is now removed"?

r37

r38

Copy link
Collaborator

@joelim-work joelim-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I meant to remove this immediately after r38 was released, but there was a lot of other changes piled up around that time due to the change freeze which I had to merge, and then I just simply forgot about this.

Regarding the changelog, I think it you can make an argument either way. The term 'deprecate' generally means a feature is discouraged, but it is still available for use. In this case the behavior of the sixel option has been changed so that it is a no-op (but raises a helpful warning for users), instead of performing its intended original functionality.

So I'm fine with just leaving the changelog as is - in any case even after this PR is merged, attempting to use set sixel true will still result in some kind of error message, so users will notice that there is something wrong with their configuration.

@CatsDeservePets CatsDeservePets merged commit 9a091a2 into gokcehan:master Nov 14, 2025
32 checks passed
@CatsDeservePets CatsDeservePets deleted the deprecate branch November 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Pull requests that introduce breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants