fix: prevent crash when scrolling #2320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation for the
scroll-up/scroll-downcommands is mostly fine but I managed to get it to crash using the following steps:<c-e>toscroll-down(the cursor is at the first row, on the second file)2<c-y>toscroll-uptwicescroll-uponce), and the secondscroll-upshould be a no-op as directory already shows the first file and cannot be scrolled up further.<c-y>lfwill crashThe logic can also be cleaned up and should have the following steps:
dir.posas much as possible (both the cursor and files will scroll)dir.ind(the cursor cannot move any further, but continue scrolling files)