refactor: simplify some implementations by modern go features #21998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21998 +/- ##
===========================================
+ Coverage 45.36% 65.87% +20.50%
===========================================
Files 244 1071 +827
Lines 13333 115703 +102370
Branches 2719 2925 +206
===========================================
+ Hits 6049 76215 +70166
- Misses 6983 35264 +28281
- Partials 301 4224 +3923
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
@stonezdj Please help to review this change, thanks. |
Signed-off-by: chlins <[email protected]>
stonezdj
approved these changes
Jun 18, 2025
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
…or#21998) Signed-off-by: chlins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes aimed at improving code readability, simplifying logic, and leveraging Go's standard library for better performance and maintainability. The most significant updates include replacing manual loops with
rangesyntax or utility functions likeslices.Containsandmaps.Copy, as well as removing unused code. Below is a categorized summary of the most important changes:Refactoring Loops for Simplification
forloops withrangesyntax in multiple functions to simplify iteration logic. Examples includeTestMaxOpenConnsinpgsql_test.go,ArrayEqualintestutils.go, andGenerateRandomStringWithLeninutils.go. [1] [2] [3]Leveraging Standard Library Functions
slices.Containsin functions likeskippedUnusedJobTypeinmonitor.goandhasCapabilityinchecker.go. [1] [2]maps.Copyto simplify map copying in functions likeDecodeincodec.goandBuildincontext.go. [1] [2]Code Cleanup
StringInSlicefromutils.goto reduce clutter and improve maintainability.Bug Fixes and Logic Adjustments
copyBlobByChunkintransfer.goto use a single expression for calculating the end range, improving clarity and reducing potential off-by-one errors.Dependency Updates
slicesandmapspackages in various files to enable the use of utility functions for slices and maps. [1] [2] [3]These changes collectively enhance the codebase by improving readability, reducing redundancy, and leveraging modern Go practices.Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: