Move releases deployment from internal Jenkins to Travis. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.travis.yml
Outdated
|
|
||
| deploy: | ||
| - provider: script | ||
| script: PUBLISH=true bash ci/build.sh |
Contributor
There was a problem hiding this comment.
no need to specify bash here, just do:
script: PUBLISH=true ci/build.sh
Member
Author
There was a problem hiding this comment.
Just copied it from script above. Should we remove it too?
Contributor
|
@ming13 it should work, the only caveat I have on mind is that current way of getting git tags in gradle scripts doesn't allow one commit to have multiple tags That can be fixed by using |
artem-zinnatullin
approved these changes
Jun 10, 2018
artem-zinnatullin
approved these changes
Jun 11, 2018
Contributor
|
lgtm! Don't forget to add env variables on Travis |
Member
Author
|
Ready to roll. The next release should be deployed from Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge I’ll do the following.
@artem-zinnatullin, anything else?