-
Notifications
You must be signed in to change notification settings - Fork 21
Change Travis language and remove caching. #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml
Outdated
| notifications: | ||
| email: false | ||
|
|
||
| before_cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I've just figured that it doesn't work because we run in Docker, we can mount cache into container tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, seems useless anyway. We spend too much time on spinning the Docker container, dependencies downloading is the least issue there is. Should I remove cache-related things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm just afraid that mavenCentral/jcenter outage (and they do happen fairly often, especially with jcenter) will bring down CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same can be applied to Docker Hub but we use it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but I have not seen Docker hub down this year while jcenter has outages almost every month
But anyway, let's remove it at least for now since it does nothing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
|
Can you please reflect cache removal in PR title or commit message? Otherwise lgtm |
No description provided.