Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dance Shoe Speed Bounding#25580

Merged
Azrun merged 5 commits intogoonstation:masterfrom
QuiteLiterallyAnything:Dress_Shoes_Fix
Feb 2, 2026
Merged

Dance Shoe Speed Bounding#25580
Azrun merged 5 commits intogoonstation:masterfrom
QuiteLiterallyAnything:Dress_Shoes_Fix

Conversation

@QuiteLiterallyAnything
Copy link
Contributor

[Bug] [Runtime] [Player Actions]

About the PR

Fixes #25572

This PR both corrects a division by zero runtime error and resolves the linked issue by bounding dance speed to reasonable BPMs.

Why's this needed?

After reproducing issue #25572, I discovered that the bug only occurs when time_per_count equals zero. I don't know exactly why it happens, but it's accompanied with a division by zero runtime error. Realistically speaking, dancing at a time per count equal to zero shouldn't even be possible-- that would just be standing. Dancing at a negative BPM also doesn't make sense, so this PR just limits player adjustments on time_per_count such that they're always greater than zero.

Dancing with a very slow time per count can allow players to maintain a prolonged and subtle sprite shift that is both potentially advantageous in combat and antithetical to the concept of dancing. (Not to mention that it's difficult to return from since you have to spam the "faster" button to get it back to a reasonable speed.) Aside from that, it also leads BPM towards zero (though it might not actually ever reach it due to the nature of whatever decaying function may be said to represent its slowing decrease).

Testing

On a debug build of the codebase I spawned a pair of dancing dress shoes and verified that the bounds worked as expected when speed was adjusted.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2026
@pgmzeta pgmzeta added C-Bug A bug that impacts usage of a feature C-Runtime Deals with runtime errors A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities labels Jan 15, 2026
@github-actions github-actions bot added S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Jan 21, 2026
@QuiteLiterallyAnything
Copy link
Contributor Author

The conflict is with an uncommunicated fix commit (6b1e70c) pushed by @Azrun five days ago. This PR is now more of a refactor.

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jan 28, 2026
@Azrun Azrun merged commit 2b0bd04 into goonstation:master Feb 2, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Bug A bug that impacts usage of a feature C-Runtime Deals with runtime errors S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dress Shoes Bug

4 participants

Comments