fix: similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode #14702

MayV · 2025-12-08T12:05:06Z

Summary

Replicate throwing error (inspired by DENY case of policy-engine) in case of non-interactive mode and requiring user confirmation for tool execution. This avoids non-interactive gemini-cli indefinitely waiting for mcp-server tool execution confirmation. This error is caught and an error response is shown to the user.

Details

The issue #11459 is only observed in case the Policy Engine is not enabled. Code flow:

When a tool call is scheduled and processed (inside _processNextInQueue() method of packages/core/src/core/coreToolScheduler.ts), it calls shouldConfirmExecute() method of packages/core/src/tools/tools.ts to determine if user approval is needed. For determining this, the flow splits here depending on whether the policy-engine is enabled or not. In case the policy-engine is not enabled, the legacy confirmation flow is used.

In case policy-engine is enabled via messageBus, it automatically convert ASK_USER decisions to DENY (check shouldConfirmExecute() method of packages/core/src/tools/tools.ts).
Else, as per the legacy flow of mcp-tools, in case the server is not trusted, user confirmation message is required (check getConfirmationDetails() method of packages/core/src/tools/mcp-tool.ts).

Finally, if the user confirmation message is required, it is checked if the tool part of --allowedTools list. If not, user confirmation message is triggered (check _processNextInQueue() method of packages/core/src/core/coreToolScheduler.ts).

The user confirmation is required for executing mcp-tools (in case the server is not trusted or the tool is not explicitly allowed). This causes the indefinite waiting of non-interactive gemini-cli on executing mcp-tools.

To solve this, the exact same logic defined in policy-engine of throwing error in case of tool deny is used. This error is caught and an error response is shown to the user (check _processNextInQueue() method of packages/core/src/core/coreToolScheduler.ts)

Related Issues

Fixes #11459

How to Validate

Follow steps to reproduce #11459

Pre-Merge Checklist

Working as expected without indefinite wait on invoking mcp-server tool in non-interactive mode:

gemini-code-assist · 2025-12-08T12:05:19Z

Summary of Changes

Hello @MayV, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the gemini-cli would indefinitely wait for user confirmation when attempting to execute tools in a non-interactive environment. By implementing a mechanism to throw an error in such cases, mirroring the behavior of the policy-engine's denial logic, the CLI now gracefully exits with an error, preventing hangs and providing immediate feedback to the user.

Highlights

Non-interactive Mode Handling: Introduced an error throw when tool execution requires confirmation in non-interactive mode, preventing indefinite waiting.
Policy Alignment: The new error-throwing logic is similar to the policy-engine's DENY behavior, ensuring consistent handling of unconfirmed tool executions.
User Experience: The change prevents the gemini-cli from hanging and provides a clear error response to the user in scenarios where tool confirmation is needed but cannot be provided.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly addresses a critical issue where gemini-cli could hang indefinitely in non-interactive mode when a tool requires user confirmation. The approach of adding a centralized check in CoreToolScheduler is sound. My only feedback is to improve the error message to be more descriptive for users who are not using the policy engine. This will help avoid confusion and make the error more actionable.

packages/core/src/core/coreToolScheduler.ts

github-actions · 2025-12-08T12:08:12Z

Size Change: +294 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	21.6 MB	+294 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

packages/core/src/core/coreToolScheduler.ts

MayV · 2025-12-10T06:44:45Z

The "Tool Call Lifecycle" section of Gemini CLI A2A documentation clearly states that the confirmation requirement is expected for tool calls. Hence do not throw error and break the flow in case of an A2A request. To identify if the request is an A2A request, a new config is added which is only set to true when an A2A request is created.

…interactive mode.

Update error description Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…n is required in non-interactive mode in legacy confirmation flow

MayV requested a review from a team as a code owner December 8, 2025 12:05

gemini-code-assist bot reviewed Dec 8, 2025

View reviewed changes

packages/core/src/core/coreToolScheduler.ts Show resolved Hide resolved

iqbalbhatti49 approved these changes Dec 8, 2025

View reviewed changes

MayV requested a review from scidomino December 8, 2025 15:03

scidomino reviewed Dec 8, 2025

View reviewed changes

packages/core/src/core/coreToolScheduler.ts Outdated Show resolved Hide resolved

scidomino approved these changes Dec 8, 2025

View reviewed changes

MayV enabled auto-merge December 8, 2025 16:49

MayV force-pushed the ni-mcptool-hang branch from 9962362 to 2667db5 Compare December 10, 2025 06:38

MayV disabled auto-merge December 10, 2025 06:40

MayV enabled auto-merge December 10, 2025 06:44

MayV disabled auto-merge December 10, 2025 06:45

MayV requested a review from scidomino December 10, 2025 06:45

MayV force-pushed the ni-mcptool-hang branch from 1f24f91 to db80242 Compare December 10, 2025 07:58

MayV enabled auto-merge December 10, 2025 08:05

MayV disabled auto-merge December 10, 2025 08:07

MayV mentioned this pull request Dec 10, 2025

Tools that require confirmation should not block indefinitely in non-interactive mode #7345

Closed

MayV changed the title ~~Similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode~~ fix: similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode Dec 10, 2025

MayV and others added 7 commits December 15, 2025 23:22

Throw error in case of requiring tool execution confirmation for non-…

6b0fddb

…interactive mode.

Update packages/core/src/core/coreToolScheduler.ts

97ffc45

Update error description Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Add tests for testing throwing error in case of tool user confirmatio…

31d1de5

…n is required in non-interactive mode in legacy confirmation flow

Fix prettier warnings

286ab22

Fix tests

ae677ed

Incorporating feedback from peer review

cb39bb8

Fix failing tests

8788e69

MayV force-pushed the ni-mcptool-hang branch from 4f03467 to 8788e69 Compare December 15, 2025 17:59

Merge branch 'main' into ni-mcptool-hang

dae9902

scidomino approved these changes Dec 15, 2025

View reviewed changes

MayV enabled auto-merge December 15, 2025 18:05

MayV added this pull request to the merge queue Dec 15, 2025

Merged via the queue into main with commit 217e2b0 Dec 15, 2025
20 checks passed

MayV deleted the ni-mcptool-hang branch December 15, 2025 18:42

This was referenced Dec 15, 2025

fix: Mark A2A requests as interactive #15107

Closed

fix: Mark A2A requests as interactive #15108

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode #14702

fix: similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode #14702

Uh oh!

MayV commented Dec 8, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 8, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

MayV commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode #14702

fix: similar to policy-engine, throw error in case of requiring tool execution confirmation for non-interactive mode #14702

Uh oh!

Conversation

MayV commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-code-assist bot commented Dec 8, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

MayV commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MayV commented Dec 8, 2025 •

edited

Loading

github-actions bot commented Dec 8, 2025 •

edited

Loading