-
Notifications
You must be signed in to change notification settings - Fork 10.5k
feat: display quota stats for unused models in /stats #14764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the user experience of the CLI's statistics display by ensuring that all models a user has access to, and their corresponding quota information, are visible, even if those models haven't been actively engaged during the current session. This change provides a more comprehensive and transparent view of available resources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the session statistics display to show quota information for all available models, even those not used in the current session. This is achieved by introducing a new buildModelRows function that combines data from used models with available quota information. The changes are logical and address the goal of the pull request. I have one high-severity suggestion to make the model name parsing more robust to prevent potential bugs with how statistics are displayed.
|
Size Change: +1.34 kB (+0.01%) Total Size: 21.6 MB
ℹ️ View Unchanged
|
Summary
Display quota stats for all availabel models even if they haven't been used yet in the current session
Details
The quota info from the backend returns a list of quota for all the models the users have access to. We should display quota stats for all the models even if the model has not been used in the current session.

Pre-Merge Checklist