Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add clarity to error messages #14879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsehgal merged 6 commits into from
Dec 13, 2025
Merged

Add clarity to error messages #14879

gsehgal merged 6 commits into from
Dec 13, 2025

Conversation

@gsehgal
Copy link
Collaborator

@gsehgal gsehgal commented Dec 10, 2025

Summary

Add clarity to the error messages return by gemini cli

Details

Current the handleAtCommand does not return a error message; it just returns a boolean flag in case of error, because of which the error messages sent back to user are very generic. In this PR we have added error message to the handleAtCommand ; to make sure the correct error messages are sent back to user.

Related Issues

google-github-actions/run-gemini-cli#266

How to Validate

Refer to bug to to re-produce and fix the issue.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@gsehgal gsehgal requested a review from a team as a code owner December 10, 2025 05:53
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 10, 2025

Summary of Changes

Hello @gsehgal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the clarity of error messages within the Gemini CLI, particularly for @ commands. By modifying the handleAtCommand function to return specific error strings, the system can now provide users with more informative feedback when operations fail, moving away from generic error notifications. This change enhances the overall user experience by making it easier to diagnose and understand issues.

Highlights

  • Enhanced Error Messaging: The handleAtCommand function now returns a specific error message when an issue occurs, instead of just a boolean flag. This allows for more detailed feedback to the user.
  • Improved User Experience: The runNonInteractive function now utilizes the detailed error messages from handleAtCommand to provide more precise FatalInputError messages to the user, improving clarity on why an @ command failed.
  • New Test Cases: Added a new test case to atCommandProcessor.test.ts to ensure handleAtCommand correctly handles user cancellation during read_many_files operations, returning shouldProceed: false and a specific error message. An existing test description was also clarified.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error reporting by propagating detailed error messages from handleAtCommand to the non-interactive CLI. The changes are logical and include a new test case to validate the error handling for user-cancelled operations. The implementation correctly modifies handleAtCommand to return an error string and updates runNonInteractive to use it, leading to more informative error messages for the user. I've identified a minor logical issue where a code path is unreachable, which could be simplified for better clarity and maintainability.

MayV
MayV reviewed Dec 10, 2025
View reviewed changes
MayV
MayV reviewed Dec 10, 2025
View reviewed changes
parthasaradhie
parthasaradhie reviewed Dec 10, 2025
View reviewed changes
@gsehgal gsehgal requested a review from jacob314 December 11, 2025 05:13
scidomino
scidomino reviewed Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@scidomino scidomino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Why are we returning an error message instead of throwing an error?

LIHUA919
LIHUA919 reviewed Dec 11, 2025
View reviewed changes
Copy link

@LIHUA919 LIHUA919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cognitive load of this logic block is quite high. Even though it works, the implementation obscures the business intent. For long-term maintainability, could we refactor this to be more explicit? Simplicity is better than complexity.

@gsehgal
Copy link
Collaborator Author

gsehgal commented Dec 11, 2025

@LIHUA919 do mean to refactor the entire function, can you explicitly state which block of code you are referring to ?

@gsehgal gsehgal added this pull request to the merge queue Dec 13, 2025
Merged via the queue into google-gemini:main with commit d9f9410 Dec 13, 2025
20 checks passed
@gsehgal gsehgal deleted the fix-266 branch December 13, 2025 01:23
LIHUA919
LIHUA919 reviewed Dec 13, 2025
View reviewed changes
Copy link

@LIHUA919 LIHUA919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job！

@gsehgal
Copy link
Collaborator Author

gsehgal commented Dec 13, 2025

great job！

@LIHUA919 if you find some part of the code difficult to understand try out codewiki.google

It is LLM powered documentation of public repositories

thacio added a commit to thacio/auditaria that referenced this pull request Dec 13, 2025
@thacio
Merge Commit 'd9f94103c': Add clarity to error messages (google-gemin…
41ca9ad 
…i#14879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthasaradhie parthasaradhie parthasaradhie left review comments

@MayV MayV MayV left review comments

@scidomino scidomino scidomino approved these changes

@MJjainam MJjainam Awaiting requested review from MJjainam

@jacob314 jacob314 Awaiting requested review from jacob314

+2 more reviewers

@LIHUA919 LIHUA919 LIHUA919 left review comments

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gsehgal @parthasaradhie @scidomino @MayV @LIHUA919