Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@abhipatel12
Copy link
Collaborator

Summary

Allowed codebase_investigator by default in the read-only policy configuration.

Details

The codebase_investigator tool is a read-only analysis tool but was missing from the default allowlist in packages/core/src/policy/policies/read-only.toml. This resulted in it requiring explicit user permission or higher privilege modes to run, despite being safe. This PR adds it to the policy with priority 50, matching other read-only tools like glob and read_file.

Related Issues

How to Validate

  1. Build the core package: npm run build -w packages/core
  2. Verify that codebase_investigator can be used without prompting for permission in default mode.
  3. Review packages/core/src/policy/policies/read-only.toml to see the new entry.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (Verified locally with integration test)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@abhipatel12 abhipatel12 requested a review from a team as a code owner December 12, 2025 17:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the use of the codebase_investigator tool by integrating it into the default read-only policy. This change ensures that a safe, read-only analysis tool is accessible by default, enhancing the user experience by removing unnecessary permission prompts for a non-privileged operation.

Highlights

  • Policy Update: The codebase_investigator tool has been added to the default read-only policy configuration, allowing it to run without requiring explicit user permission.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions
Copy link

Size Change: -2 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 21.6 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the codebase_investigator tool to the default read-only policy. While this seems correct based on the tool's current capabilities, I have identified a potential high-severity security risk stemming from an inconsistency in the agent's definition. My review comment details this risk and recommends resolving the underlying issue before this change is merged.

Comment on lines +58 to +61
[[rule]]
toolName = "codebase_investigator"
decision = "allow"
priority = 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While codebase_investigator currently uses only read-only tools, allowing it by default introduces a potential security risk due to an inconsistency in its definition in packages/core/src/agents/codebase-investigator.ts.

Specifically:

  • The agent's prompt (line 109) states it can use the web_fetch tool.
  • The agent's toolConfig (line 85) does not grant it this capability.

The web_fetch tool is not present in this read-only.toml allowlist, which implies it is not considered safe to run by default without user confirmation. If a future change "fixes" the agent by adding web_fetch to its toolConfig, this policy rule would silently permit a potentially unsafe tool to run.

This latent security vulnerability should be addressed before whitelisting the agent. I recommend resolving the inconsistency in codebase-investigator.ts (e.g., by removing the mention of web_fetch from the prompt) before merging this change.

@abhipatel12 abhipatel12 added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 12cbe32 Dec 12, 2025
19 of 20 checks passed
@abhipatel12 abhipatel12 deleted the fix/codebase-investigator-policy branch December 12, 2025 17:36
@abhipatel12
Copy link
Collaborator Author

/patch preview

@github-actions
Copy link

βœ… Patch workflow(s) dispatched successfully!

πŸ“‹ Details:

  • Channels: preview
  • Commit: 12cbe320e44b236919eead036c5e326c4d167100
  • Workflows Created: 1

πŸ”— Track Progress:

@github-actions
Copy link

πŸš€ Patch PR Created!

πŸ“‹ Patch Details:

πŸ“ Next Steps:

  1. Review and approve the hotfix PR: #15003
  2. Once merged, the patch release will automatically trigger
  3. You'll receive updates here when the release completes

πŸ”— Track Progress:

@github-actions
Copy link

πŸš€ Patch Release Started!

πŸ“‹ Release Details:

  • Environment: prod
  • Channel: preview β†’ publishing to npm tag preview
  • Version: v0.21.0-preview.3
  • Hotfix PR: Merged βœ…
  • Release Branch: release/v0.21.0-preview.3-pr-15000

⏳ Status: The patch release is now running. You'll receive another update when it completes.

πŸ”— Track Progress:

@github-actions
Copy link

βœ… Patch Release Complete!

πŸ“¦ Release Details:

πŸŽ‰ Status: Your patch has been successfully released and published to npm!

πŸ“ What's Available:

πŸ”— Links:

thacio added a commit to thacio/auditaria that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants