-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Adding list sub command to memoryCommand to list the path of GEMINI.md files #10108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r GEMINI.md files used in hierarchical memory.
Summary of ChangesHello @sgnagnarella, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant quality-of-life improvement for users interacting with the CLI's hierarchical memory feature. By adding a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new /memory list command to display the paths of GEMINI.md files being used. The implementation involves modifying loadHierarchicalGeminiMemory to return file paths and updating the Config object to store them. The changes are well-implemented, and tests have been updated accordingly.
However, I found a significant issue where the file paths are not updated when memory is refreshed, which would lead to the new /memory list command showing stale data. I've left a comment with details on how to fix this.
…fter the refresh command. Updated refresh command to update GEMINI.md file paths. Updated perform memory refresh method on AppContainer to also update FilePaths in the config.
abhipatel12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this!
…ist the path of GEMINI.md files (google-gemini#10108)
…d files (google-gemini#10108) Co-authored-by: Abhi <[email protected]>
TLDR
Adding list sub command to memoryCommand to list the path of GEMINI.md files.
Dive Deeper
Reviewer Test Plan
Execute the list sub command from the memory command. Test a scenario where long term memory has been added (e.g. "Remember that my favorite color is blue") and make sure that the path for ~/.gemini/GEMINI.md file is listed.
Testing Matrix
Linked issues / bugs
This PR also makes progress on enabling users to troubleshot The CLI shows that it's using 2 GEMINI.md files even though there is only one. It happened after adding a new memory. #8741