Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core, cli): Implement sequential approval. #11593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshualitt merged 1 commit into from
Oct 27, 2025
Merged

feat(core, cli): Implement sequential approval. #11593

joshualitt merged 1 commit into from
Oct 27, 2025

Conversation

@joshualitt
Copy link
Collaborator

@joshualitt joshualitt commented Oct 21, 2025 •
edited
Loading

TLDR

Implements sequential approval in-line with execution.

Reviewer Test Plan

Execute multiple tool calls at once, confirm sequential approval in-line with execution.

Testing Matrix

🍏 🪟 🐧
npm run ❓ ❓ ✔️
npx ❓ ❓ ❓
Docker ❓ ❓ ❓
Podman ❓ - -
Seatbelt ❓ - -

Linked issues / bugs

Fixes #11541

@joshualitt joshualitt force-pushed the jl/sequential-approval branch 2 times, most recently from 98d864f to b602105 Compare October 21, 2025 23:30
@joshualitt joshualitt changed the title Jl/sequential approval feat(core, cli): Implement sequential approval. Oct 21, 2025
@joshualitt joshualitt marked this pull request as ready for review October 21, 2025 23:33
@joshualitt joshualitt requested a review from a team as a code owner October 21, 2025 23:33
@joshualitt joshualitt force-pushed the jl/sequential-approval branch from b602105 to 32ae84c Compare October 21, 2025 23:52
@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

Size Change: +4 kB (+0.02%)

Total Size: 20.2 MB

Filename Size Change
./bundle/gemini.js 20.2 MB +4 kB (+0.02%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@joshualitt joshualitt force-pushed the jl/sequential-approval branch 5 times, most recently from c392863 to 97e0f59 Compare October 23, 2025 03:12
@joshualitt joshualitt requested review from allenhutchison, anj-s and jacob314 and removed request for jacob314 October 23, 2025 17:16
@joshualitt joshualitt force-pushed the jl/sequential-approval branch from 97e0f59 to caaf900 Compare October 23, 2025 19:06
allenhutchison
allenhutchison approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@allenhutchison allenhutchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I spent a bunch of time manually testing and I like the changes.

@joshualitt
Copy link
Collaborator Author

joshualitt commented Oct 23, 2025

Thanks @allenhutchison !!

FYI @anj-s @jacob314 @NTaylorMullen , evals looked reasonable, I'm going to land this unless there are objections.

@joshualitt joshualitt force-pushed the jl/sequential-approval branch 2 times, most recently from 86b24b0 to dcc4503 Compare October 25, 2025 01:15
@joshualitt joshualitt force-pushed the jl/sequential-approval branch from dcc4503 to d323ab6 Compare October 27, 2025 16:29
@joshualitt joshualitt enabled auto-merge October 27, 2025 16:46
@joshualitt joshualitt added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 541eeb7 Oct 27, 2025
30 of 34 checks passed
@joshualitt joshualitt deleted the jl/sequential-approval branch October 27, 2025 17:11
thacio added a commit to thacio/auditaria that referenced this pull request Oct 28, 2025
@thacio
Merge Commit '541eeb7': feat(core, cli): Implement sequential approva…
2ad6d3a 
…l. (google-gemini#11593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allenhutchison allenhutchison allenhutchison approved these changes

@anj-s anj-s Awaiting requested review from anj-s

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Process tool call approvals sequentially and in-line with execution

2 participants

@joshualitt @allenhutchison