-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[feat]: Add /extensions restart command
#12739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jakemac53, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new /extensions restart command, empowering users to manually refresh the state of their extensions. This functionality is available regardless of whether the automatic extension reloading experiment is active, offering a consistent method for applying updates or resolving issues. The change also includes updates to the extension state management, ensuring the user interface accurately reflects when an extension has been successfully restarted. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new /extensions restart command, which is a valuable addition for managing extensions. The implementation is solid and includes comprehensive tests. I've identified one high-severity issue related to user feedback when no extensions match the restart criteria, which could lead to confusion. Addressing this will improve the user experience of the new command.
|
Size Change: +3.89 kB (+0.02%) Total Size: 20.5 MB
ℹ️ View Unchanged
|
|
LGTM! The implementation of One minor suggestion for UX improvement: In |
|
|
||
| context.ui.addItem( | ||
| { | ||
| type: MessageType.INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or tweak so the info icon isn't used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jacob314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once the multiple info messages are cleaned up and there is a clearer error for invalid extension names.
…s the primary color and remove icon from second one
|
Note that this should also be very useful when working locally on a linked extension - you can edit the main repo and then restart the extension to see your changes. |
| const infoItem: HistoryItemInfo = { | ||
| type: MessageType.INFO, | ||
| text: `${extensionsToRestart.length} extension${s} restarted successfully.`, | ||
| icon: ' ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'. ' is not an icon. make the api clearer or at least defined a constant like OMIT_ICON
jacob314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI looks much more polished with these updates. Thanks for the fixes.
Summary
Now that we have all extension reloading features working, this adds an
/extensions restartcommand to explicitly restart extensions.This command exists currently without opting into the extension reloading experiment - so that experiment just makes it automatic, but there is a way to restart extensions generally without opting in to anything.
Details
Also adds an event for the extensions update state reducer to update the "(updated, needs restart)" message for extensions after they have been updated.
Related Issues
Related to #11108
How to Validate
Update an extension and then restart it - you should see all the new features and also if you do
/extensions listyou should see its updated state is now green.Pre-Merge Checklist