[#5356] Minor fix: Remove duplicate binding and add complete navigation command #5884
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Lee-WonJun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I'm addressing two minor fixes in this pull request: first, simplifying key bindings by removing redundant uppercase entries, as key.name is consistently lowercase across environments. Second, I'm enhancing auto-completion usability by adding dedicated navigation commands, providing a more intuitive way to interact with suggestions.
Highlights
- Key Binding Refinement: I've streamlined the key binding configuration by removing redundant uppercase key definitions for commands like QUIT and EXIT. This change is based on the observation that key.name is always returned in lowercase, making the uppercase bindings unnecessary.
- Enhanced Auto-completion Navigation: I've introduced new COMPLETION_UP and COMPLETION_DOWN commands. These commands, bound to arrow keys and Ctrl+P/Ctrl+N, provide dedicated and intuitive navigation within auto-completion suggestions, improving the user experience.
- Input Prompt Integration: The InputPrompt component has been updated to leverage the newly defined COMPLETION_UP and COMPLETION_DOWN commands for navigating auto-completion lists. This ensures that the UI correctly responds to the new navigation key bindings.
- Test Suite Alignment: I've updated the keyMatchers.test.ts file to reflect these changes. This includes adding tests for the new completion navigation commands and removing the specific test for key name case sensitivity, aligning the tests with the observed behavior of key.name.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces dedicated commands and key bindings for navigating auto-completion suggestions, which improves code clarity. It also simplifies the key bindings for QUIT and EXIT by removing redundant uppercase variants, based on the correct assumption that key.name from Node's readline is always lowercase for letter keys. The changes are well-tested. However, I found a critical issue in a test file that will prevent the code from compiling.
| // Original hard-coded logic (for comparison) | ||
| const originalMatchers = { | ||
| const originalMatchers: Record<Command, (key: Key) => boolean> = { | ||
| [Command.RETURN]: (key: Key) => key.name === 'return', |
There was a problem hiding this comment.
The code introduces a reference to Command.RETURN, but RETURN is not a member of the Command enum. This will cause a compilation error. This seems to be a remnant of a previous change and should be removed.
There was a problem hiding this comment.
It exists in Command, but it seems that this judgment was made because there’s no other related code in the rest of this PR.
jacob314
left a comment
There was a problem hiding this comment.
Thanks for the quick follow up!
…on command (#5884) Co-authored-by: Jacob Richman <[email protected]>
…ate binding and add complete navigation command (google-gemini#5884)
…lete navigation command (google-gemini#5884) Co-authored-by: Jacob Richman <[email protected]>
…lete navigation command (google-gemini#5884) Co-authored-by: Jacob Richman <[email protected]>
…lete navigation command (google-gemini#5884) Co-authored-by: Jacob Richman <[email protected]>
TLDR
Apply minor comment (@jacob314) for #5356:
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
#5356