This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Fix for _setmode usage #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix didn't work in all situations. I suspect it's because it was changing the state of the fd back to _O_TEXT mode without synchronising with fflush(). Changing the mode back to _O_TEXT isn't actually needed (see discussion in google#56,) so just remove the call.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix didn't work for me. I suspect because it changed the state of the fd back to _O_TEXT without flushing the file beforehand, so when the end of the file was flushed to the _O_TEXT fd, it got the \r\n conversion again. As mentioned at the end of #56, I don't think it's necessary to change the stream back to _O_TEXT, so this just removes that call.
This also removes a redundant comment (the code should work regardless of new-line conversion now) and indents another comment.
Tested with MSYS2/mingw-w64 on Windows 8.1 with a few small text files and one larger binary file.