fix(types): restore pipe(file: string) type declaration
#1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the type declaration for the pipe method when a file string parameter is used. It adds a new overload for pipe(file: string) and updates related return types in the ProcessPromise class to ensure proper type inference.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test-d/core.test-d.ts | Adds a unit test verifying the new pipe(file: string) return type. |
| src/core.ts | Introduces the PromisifiedStream type alias and updates pipe overloads to correctly return PromisifiedStream for file and Writable inputs. |
Files not reviewed (2)
- .size-limit.json: Language not supported
- package.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1208