Replace node-fetch with node-fetch-native
#599
Closed
+11
−128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware this task is already assigned to others, but here I'm proposing it as a bug fix for Deno targeting zx v7.
node-fetchseems to cause a infinite loop in Deno:So why
node-fetch-native? To sum its readme up:fetchwhen available (thus doesn't break Deno)Thus I consider it a good alternative to removing
node-fetchentirely in v8.This change does introduce a small issue: if TypeScript users have outdated
@types/nodethenRequestInfoandRequestInittypes will be missing. I assume this is rare if they are using TypeScript anyway.