Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: properly promisify pipe stream args #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: properly promisify pipe stream args #921

merged 2 commits into from
Oct 29, 2024

Conversation

@antongolub
Copy link
Collaborator 

const p = $`echo "hello"`
  .pipe(
    new Transform({
      transform(chunk, encoding, callback) {
        callback(null, String(chunk).toUpperCase())
      },
    })
  )
  .pipe(fs.createWriteStream('/tmp/output2.txt'))
  
// p is a WriteStream instance with PromiseLike mixin
await p // is void
  • Tests pass
  • Appropriate changes to README are included in PR

@antongolub antongolub requested a review from antonmedv October 29, 2024 20:30
@antonmedv antonmedv merged commit 3871229 into google:main Oct 29, 2024
21 checks passed
antongolub added a commit to antongolub/zx that referenced this pull request Oct 31, 2024
@antongolub
refactor: pass stream err to pipe promise rejection
5865338 
continues google#921
antongolub added a commit to antongolub/zx that referenced this pull request Oct 31, 2024
@antongolub
refactor: pass stream err to pipe promise rejection
3cdb547 
continues google#921
@antongolub antongolub mentioned this pull request Oct 31, 2024
Merged
1 task
@antongolub antongolub deleted the fix-pipe-stream-promisify branch October 31, 2024 09:52
antonmedv pushed a commit that referenced this pull request Oct 31, 2024
@antongolub
refactor: pass stream err to pipe promise rejection (#928)
6eb540f 
continues #921
@hfhchan-plb hfhchan-plb mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonmedv antonmedv antonmedv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antongolub @antonmedv