Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add control over timeouts for SSE#407

Merged
kdroste-google merged 3 commits intogoogle:mainfrom
kdroste-google:web-sse-timeout
Dec 11, 2025
Merged

Add control over timeouts for SSE#407
kdroste-google merged 3 commits intogoogle:mainfrom
kdroste-google:web-sse-timeout

Conversation

@kdroste-google
Copy link
Collaborator

@kdroste-google kdroste-google commented Dec 9, 2025

Added a new flag --sse-write-timeout which gives control over the write timeout specifically for run_sse. Other endpoints are not affected

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 9, 2025

Summary of Changes

Hello @kdroste-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the configurability of the API by introducing a dedicated write timeout for Server-Sent Events (SSE) connections. This allows administrators to fine-tune the behavior of streaming endpoints, specifically "run_sse", to prevent connections from timing out prematurely or holding resources for too long, thereby improving the robustness and resource management of the application.

Highlights

  • Configurable SSE Write Timeout: Introduced a new command-line flag "--sse-write-timeout" to specify the write timeout for Server-Sent Events (SSE) responses.
  • Targeted Control: This timeout specifically applies to the "run_sse" endpoint, ensuring other API endpoints remain unaffected.
  • Default Value: The default write timeout for SSE is set to 120 seconds.
  • Implementation Detail: Utilizes "http.NewResponseController" to set a custom write deadline for SSE connections, overriding server-wide timeouts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kdroste-google kdroste-google linked an issue Dec 9, 2025 that may be closed by this pull request
Sub agent with loop is exiting earlier than expected when using webui, and is showing as loading. #386
Closed
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new --sse-write-timeout flag to control the write timeout for SSE endpoints. The change is correctly propagated from the command-line flag down to the RunSSEHandler. My main feedback is to restore an upfront check for streaming support that was removed, to ensure the handler fails fast if streaming is not available. Otherwise, the implementation is solid.

dpasiukevich
dpasiukevich reviewed Dec 11, 2025
View reviewed changes
@kdroste-google kdroste-google merged commit 72ab97b into google:main Dec 11, 2025
3 checks passed
davidli2010 pushed a commit to davidli2010/adk-go that referenced this pull request Feb 4, 2026
@kdroste-google
Add control over timeouts for SSE (google#407)
185312a 
* Add control over timeouts for SSE

* Linter fix

* fixed wording for errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baptmont baptmont baptmont approved these changes

@dpasiukevich dpasiukevich dpasiukevich approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sub agent with loop is exiting earlier than expected when using webui, and is showing as loading.

3 participants

@kdroste-google @baptmont @dpasiukevich