Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove the cmd/launcher/adk package#252

Merged
dpasiukevich merged 3 commits intomainfrom
launcher-config
Nov 11, 2025
Merged

Remove the cmd/launcher/adk package#252
dpasiukevich merged 3 commits intomainfrom
launcher-config

Conversation

@rakyll
Copy link
Member

@rakyll rakyll commented Nov 11, 2025 •
edited
Loading

Moves the Config to the launcher project, because the config type represents launcher configuration.

Updates #226.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 11, 2025

Summary of Changes

Hello @rakyll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant refactoring by removing the cmd/launcher/adk package. The core Config struct, essential for defining common parameters for agent and launcher execution, has been relocated to the cmd/launcher package. This change simplifies the project's structure by centralizing configuration definitions, leading to a cleaner and more maintainable codebase by reducing unnecessary package dependencies.

Highlights

  • Package Removal: The cmd/launcher/adk package, which previously housed the Config struct, has been entirely removed from the codebase.
  • Configuration Struct Relocation: The Config struct, along with its associated imports (e.g., session.Service, artifact.Service), has been moved directly into the cmd/launcher/launcher.go file, consolidating its definition within the main launcher package.
  • Type Reference Updates: All references to the old *adk.Config type across various launcher components (console, universal, web, webui, api) and example applications have been updated to *launcher.Config to reflect the new location of the configuration struct.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the codebase by removing the cmd/launcher/adk package and relocating the Config struct to the cmd/launcher package. The changes are mostly straightforward and have been applied consistently across the affected files. I have a few minor suggestions to improve naming consistency and code clarity following this refactoring.

@dpasiukevich dpasiukevich merged commit e385395 into main Nov 11, 2025
3 checks passed
@kdroste-google kdroste-google mentioned this pull request Nov 12, 2025
Closed
@dpasiukevich dpasiukevich deleted the launcher-config branch January 30, 2026 11:25
davidli2010 pushed a commit to davidli2010/adk-go that referenced this pull request Feb 4, 2026
@rakyll @dpasiukevich
Remove the cmd/launcher/adk package (google#252)
3cd2512 
* Remove the cmd/launcher/adk package

* Rename adkConfig to config

* Remove config parameter in AddSubrouter method

---------

Co-authored-by: Dmitry Pasiukevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpasiukevich dpasiukevich dpasiukevich approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakyll @dpasiukevich