feat: pass event actions through a2a#304
Conversation
Summary of ChangesHello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature to reliably transmit the 'escalate' status across the Agent-to-Agent (A2A) communication boundary. This ensures that if an agent's session event is marked for escalation, this critical status is preserved and communicated to downstream callers via the terminal task status update metadata, allowing for appropriate handling and response. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to pass an escalate status through the A2A protocol. The changes involve adding an escalate flag to the A2A message metadata when a session.Event has Actions.Escalate set. The server-side processor tracks this flag across multiple events and ensures it's included in the final terminal event. This allows the remote agent to reconstruct the escalate action correctly. The implementation is accompanied by thorough test updates, including new test cases for the escalation flow. The changes are logical and well-implemented. I have one suggestion for improving the robustness of metadata handling.
pass Escalate and TransferToAgent through a2a
The changes are mostly test updates.
Actions.Escalatewas set on asession.Eventit will be passed to callers in the terminal task status updateMetadata.RemoteAgentwill set it back asActions.Event(handled inadka2a.ToSessionEvent).