Fix mcp tool convert, null responseJsonSchema#381
Conversation
Summary of ChangesHello @baptmont, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the conversion logic for MCP tools by ensuring that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where responseJsonSchema was being set even for tools without an output schema. The change correctly adds a condition to only set this field if an output schema exists. This is a good fix that improves the robustness of the tool conversion logic. The implementation is clear and correct.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug where nil schemas in MCP tools could cause a crash when being converted for use with the LLM. The fix prevents nil schema pointers from being assigned to interface fields, which avoids incorrect JSON serialization. The change is logical and well-explained. I've added one comment suggesting the addition of unit tests to cover the fixed scenarios and prevent future regressions.
* Fix mcp tool convert to only set responseJsonSchema if mcp tool has output schema. * Add comment to mcp convertTool * Add nil validation for t.InputSchema
Fix mcp tool convert to only set responseJsonSchema if mcp tool has output schema.