Fix spurious warning 'misc-use-anonymous-namespace' (#1860) #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables 'misc-use-anonymous-namespace' for usage of the BENCHMARK macro. This warning is spurious, and the variable declared by the BENCHMARK macro can't be moved into an annonymous namespace. We don't want to disable it globally, but it can be disabled locally, for the `BENCHMARK` statement, as this warning appears downstream for users. See: https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics
LebedevRI
reviewed
Oct 10, 2024
| BaseClass##_##Method##_Benchmark | ||
|
|
||
| #define BENCHMARK_PRIVATE_DECLARE(n) \ | ||
| /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */ \ |
There was a problem hiding this comment.
Can this use // comment style, like elsewhere in the project?
There was a problem hiding this comment.
That was what I originally tried to use, but the answer is no. The preprocessor interprets the \ at the end of the line as extending the comment to the next line. If you try to compile it, it fails with error: multi-line comment [-Werror,-Wcomment].
The comment has to be scoped by using the /* */ syntax, since the comment is embedded into the macro.
I also tried putting the comment before the macro, but that doesn't work, since the error occurs at the point of expansion.
LebedevRI
approved these changes
Oct 10, 2024
|
@codeinred thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables 'misc-use-anonymous-namespace' for usage of the BENCHMARK macro. This warning is spurious, and the variable declared by the BENCHMARK macro can't be moved into an annonymous namespace.
We don't want to disable it globally, but it can be disabled locally, for the
BENCHMARKstatement, as this warning appears downstream for users.See:
https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics
Before: (warning shown)
After: (no warnings)