fix: remove clang-cl compilation warning #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/MPflag only applies tocl, notclfrontends to other compilers (e.g.clang-cl,icx-cletc), whereas theMSVCcmake variable applies to every compiler with aclfrontend. Therefore, we need to reduce the scope of/MPto only MSVC'scl, so that the otherclfrontends can compile without warnings.Fixes #1869
Reproduction steps to test solution on Windows with the LLVM toolchain installed: