Added a PcapSnooper class #865
Open
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class implements a bumble snooper that writes PCAP records. It can write to either a file or a named pipe. The latter is useful to bridge with wireshark extcap for live logging.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I fixed the formatting issues that came up in the checks by running black and making minimal manual adjustments. |
Collaborator
|
You can use |
zxzxwu
reviewed
Jan 16, 2026
| PCAP_MAGIC = 0xa1b2c3d4 | ||
| DLT_BLUETOOTH_HCI_H4_WITH_PHDR = 201 | ||
|
|
||
| def __init__(self, fifo): |
Collaborator
There was a problem hiding this comment.
Should have annotation here
Author
Ah perfect! I'll do that and update soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built a bumble HCI logging bridge for live logging with Wireshark.
It simply plugs together bumble's snooper concept with a Wireshark extcap script via a named pipe.
You can see the result here:
https://github.com/willnix/bumble-wireshark
I thought the bumble part of it could be useful to others, hence I'm opening this PR.
The class implements a bumble snooper that writes PCAP records. It can write to either a file or a named pipe.
The latter is what I use to bridge with Wireshark but I thought logging to a PCAP file might sometimes also be handy.
I ran
invoke project.lint -d "", fixed what came up and generally tried to stick very close to the existing structure.What I'm not super happy with is the text duplication in the docstring, but I wasn't really sure what else to do.