Update the ConvertToNative API documentation and strings.join #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpbetz let me know if this addresses your use case, and also whether the updated functionality will work with your object types. |
jpbetz
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
ConvertToNativeAPI docs to clarify the call contract.The change also introduces a refactor of the
strings.joinmethod whichdoes not rely on
ConvertToNative, but rather uses thetraits.Listerwithan expectation that all contained elements will be
types.Stringvalues.This change can be taken advantage of using
ext.StringsVersion(2)ifyou are using extension versioning. If you are not using extension versioning,
the change will be default enabled.
The functionality should be equivalent with the prior behavior, though there
are some limited cases where a
ConvertToNativemight succeed whenthe new approach might fail.
Closes #688