Throw SSLException in SSL_set1_ech_config_list #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6e2f91 to
49cfcbe
Compare
Prior to this change, NativeCrypto.SSL_set1_ech_config_list would throw a OpenSSLX509CertificateFactory.ParsingException. Since the config list is not directly linked to that exception, use the more generic SSLException instead. Update the Java declaration to explicitly throws this exception. NativeCrypto.SSL_ech_accepted was found to raise a similar exception. Simply return false.
49cfcbe to
b14a137
Compare
miguelaranda0
approved these changes
Oct 14, 2025
bjiang7
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, NativeCrypto.SSL_set1_ech_config_list would throw a OpenSSLX509CertificateFactory.ParsingException. Since the config list is not directly linked to that exception, use the more generic SSLException instead. Update the Java declaration to explicitly throws this exception.
NativeCrypto.SSL_ech_accepted was found to raise a similar exception. Simply return false.