Fix SSE4.2 arch flag for MSVC in CMake config. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you edit the commit message to provide some more detail? |
The old flag was a copy-paste error. We only use /arch:NOTYET for the ARM64-specific hardware accelerated implementation, because Visual Studio does not yet have an equivalent to -march=armv8-a+crc+crypto.
Member
Author
|
@cmumford PTAL? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old flag was a copy-paste error. We only use /arch:NOTYET for the ARM64-specific hardware accelerated implementation, because Visual Studio does not yet have an equivalent to -march=armv8-a+crc+crypto.