Fix MSVC warnings in crc32c_unittest.cc #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmumford
reviewed
Aug 31, 2017
src/crc32c_unittest.cc
Outdated
|
|
||
| for (size_t i = 0; i < 32; ++i) | ||
| buf[i] = static_cast<char>(0xff); | ||
| buf[i] = static_cast<char>(-1); // 0xff causes warning C4309 on MSVC. |
Contributor
There was a problem hiding this comment.
What about?
buf[i] = '\xff'
Member
Author
There was a problem hiding this comment.
Done.
Sweet, I didn't think about that! Thanks!
This also modifies the CMake configuration, so relevant build targets will be compiled with /WX (warnings-as-errors) on MSVC. This should help us catch similar errors in CI in the future.
Member
Author
|
@cmumford Thank you for the quick review! PTAL? |
Member
Author
|
@cmumford Thank you very much for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also modifies the CMake configuration, so relevant build targets will be compiled with /WX (warnings-as-errors) on MSVC. This should help us catch similar errors in CI in the future.
This fixes the compile errors in https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_x64_Builder__dbg_%2F57719%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout