Turn enable HIR types feature flag into a noop. #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9067766 to
8cd1ba1
Compare
With the removal of HIR types, we could eventually remove SugaredTy as everywhere we construct it now uses `missing_hir`. I've left that as future work to avoid too much refactoring in the CL that removes HIR types. Some of the tests were broken and it didn't appear obvious how to update them to allow depending on ffi_11, so I've removed them in favor of relying on primitives types test. PiperOrigin-RevId: 845392864
8cd1ba1 to
689fc42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn enable HIR types feature flag into a noop.
With the removal of HIR types, we could eventually remove SugaredTy as
everywhere we construct it now uses
missing_hir. I've left that asfuture work to avoid too much refactoring in the CL that removes HIR
types.
Some of the tests were broken and it didn't appear obvious how to update them to allow depending on ffi_11, so I've removed them in favor of relying on primitives types test.